feat: add dependentSchemas keyword handler#168
Open
HasinAmir wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Implements the missing
dependentSchemaskeyword handler inprocessAST.ts.Problem
The
dependentSchemashandler was commented out, causing the fallbackhandler to trigger with " This keyword handler is not implemented yet!"
for any schema using this keyword.
Solution
After inspecting the AST, I found Hyperjump compiles
dependentSchemasas an array of
[propertyName, schemaUri]tuples , same shape aspatternProperties. The handler iterates these tuples and callsprocessASTfor each, creating child nodes labeleddependentSchemas["propertyName"]connected to the parent.Testing
Tested locally with a schema using
dependentSchemas,child nodesrender correctly with edges connecting to the parent.