Add editor placeholder support and handle empty schema validation gracefully#150
Open
riya-kaurav wants to merge 5 commits into
Open
Add editor placeholder support and handle empty schema validation gracefully#150riya-kaurav wants to merge 5 commits into
riya-kaurav wants to merge 5 commits into
Conversation
Contributor
|
Kindly bump the correct version as per - 
|
Author
|
Version bumped as suggested. |
Contributor
|
It should be 0.5.7-beta |
Author
|
Version bumped to 0.5.7-beta as suggested. |
itvi-1234
reviewed
Mar 4, 2026
| onMount={handleEditorDidMount} | ||
| /> | ||
| <Editor | ||
| height="90%" |
Contributor
There was a problem hiding this comment.
Spacing and indentation can be improved
Author
|
i have completed all the suggested improvements. If there’s anything else that needs to be updated, please let me know |
itvi-1234
reviewed
Mar 4, 2026
itvi-1234
reviewed
Mar 4, 2026
| status: "success", | ||
| message: VALIDATION_UI["success"].message, | ||
| } | ||
| status: "success", |
Author
|
I've reverted the unintended formatting changes in the validation block. Only the placeholder addition remains. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the editor user experience by:
placeholderoption.Previously, when the editor was empty, validation logic could still attempt to parse the schema, which resulted in an error message being displayed. Additionally, placeholder behavior was not implemented using Monaco’s native support.
This update ensures cleaner UX and better behavior across both light and dark themes.
What kind of change does this PR introduce
Issue Number
Closes #149
Screenshots/Video
Light Theme
Dark Theme
Does this PR introduce a breaking change?
No.
If relevant, did you update the documentation?
No documentation update was required.
Testing
Does this PR introduce a breaking change?
No.
If relevant, did you update the documentation?
No documentation update was required.
Testing