Restyle the neutral notification as a plain bordered card - #68
Merged
Conversation
The neutral type swaps its gray fill for the default background with a border, and mutes the leading icon instead of inheriting the text color. A notification without a Text now treats the description as the main message: full-size, inheriting the type's foreground, and vertically centered with the icon and any actions on a single row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for popui-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The compiled stylesheet conflicted; rebuilt it from the merged sources so it carries both branches' utility classes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mariocnovoa
approved these changes
Sep 1, 2026
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # assets/popui.css Co-authored-by: methodofaction <51445+methodofaction@users.noreply.github.com>
Contributor
Resolved. I merged |
Co-authored-by: methodofaction <51445+methodofaction@users.noreply.github.com>
Contributor
Done — I merged the latest |
# Conflicts: # assets/popui.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
neutralnotification type swaps its graybg-background-default-tertiaryfill for a plain bordered card:bg-background border border-border text-foreground.text-foreground-default-secondary) instead of inheriting the text color, so it reads gray against the plain surface. Colored types keep their tinted icons.Textnow treats the description as the main message: it renders attext-baseinheriting the type's foreground (instead of the mutedtext-smsubline), and the icon, message, and actions vertically center on a single row. This applies to all types, not just neutral.Why
Matches the updated design for neutral notifications — a light card with a gray info icon and an action button on the right, e.g. "If you want to make any change in your subscriptions, please contact sales / [Contact sales]". These notifications often carry no title, and the old layout dropped the actions onto a second row below the message with top-aligned icons.
Notes for reviewers
*_templ.goandassets/popui.css(picks up the new.text-inheritrule).🤖 Generated with Claude Code