Skip to content

docs: update README with correct tax country code and pricing methods - #935

Merged
samlown merged 1 commit into
invopop:mainfrom
christiandopico:doc/update-readme
Sep 1, 2026
Merged

docs: update README with correct tax country code and pricing methods#935
samlown merged 1 commit into
invopop:mainfrom
christiandopico:doc/update-readme

Conversation

@christiandopico

@christiandopico christiandopico commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Changes

Fix compile errors in README example:

  • Updates the README invoice example to use the correct tax and ISO country-code helpers, pointer-based pricing, and the current tax category constant.

Pre-Review Checklist

  • Opened this PR as a draft
  • Read the CONTRIBUTING.md guide.
  • Performed a self-review of my code.
  • Added thorough tests with at least 90% code coverage.
  • Modified or created example GOBL documents to show my changes in use, if appropriate.
  • Added links to the source of the changes in tax regimes or addons, either structured or in the comments.
  • Run go generate . to ensure that the Schemas and Regime data are up to date.
  • Reviewed and fixed all linter warnings.
  • Been obsessive with pointer nil checks to avoid panics.
  • Updated the CHANGELOG.md with an overview of my changes.
  • Marked this PR as ready for review.

And if you are part of the org:

  • Requested a review from Copilot and fixed or dismissed (with a reason) all the feedback raised.
  • Requested a review from @samlown.

@christiandopico
christiandopico marked this pull request as draft August 24, 2026 15:30
@christiandopico
christiandopico marked this pull request as ready for review August 24, 2026 15:30

@samlown samlown left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (8652979) to head (8ca6383).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #935   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         327      327           
  Lines       17732    17732           
=======================================
  Hits        16845    16845           
  Misses        547      547           
  Partials      340      340           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@samlown
samlown merged commit 879945d into invopop:main Sep 1, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants