Skip to content

net: re-countersigning supersedes a party's own earlier signatures - #926

Merged
samlown merged 1 commit into
mainfrom
countersignature-supersession
Aug 11, 2026
Merged

net: re-countersigning supersedes a party's own earlier signatures#926
samlown merged 1 commit into
mainfrom
countersignature-supersession

Conversation

@samlown

@samlown samlown commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Observed live after the first complete verification round: the published envelope carried four signatures — the subject's, the verifier's, and two Authority countersignatures (the registration round's and the verification round's), with more to come on every renewal.

Spec §5.3 now requires supersession: a party re-countersigning an envelope MUST replace its own earlier countersignatures (it may never touch another party's). Beyond the clutter, this is a correctness rule — a lingering older signature could assert a verifier the Authority has since revoked, and consumers scanning all signatures would still see it as verified until the old exp passed. Steady state is exactly three signatures: subject, Authority (with verifier), verifier.

Companions implementing it: invopop/gobl.lookup and invopop/gobl.kyb.sandbox strip their own earlier signatures before countersigning.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (5b286a7) to head (7dad329).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #926   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         327      327           
  Lines       17732    17732           
=======================================
  Hits        16845    16845           
  Misses        547      547           
  Partials      340      340           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@samlown
samlown merged commit c7be72d into main Aug 11, 2026
4 checks passed
@samlown
samlown deleted the countersignature-supersession branch August 11, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant