Reference the XRechnung addon key as a constant - #125
Open
pedrorfdez wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the UBL XRechnung context to avoid importing the German XRechnung addon package purely to reference its addon key, preventing future import cycles as the German addons move modules.
Changes:
- Remove the
gobl/addons/de/xrechnungimport fromcontext.go. - Inline the XRechnung V3 addon key as a literal
cbc.Keyand document why.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
pedrorfdez
force-pushed
the
de-addon-key-literal
branch
from
August 12, 2026 10:43
53cee81 to
4f71881
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 28 28
Lines 2170 2170
=======================================
Hits 1767 1767
Misses 265 265
Partials 138 138 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pedrorfdez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContextXRechnungimportedgobl/addons/de/xrechnungonly to name the addon key. Those addon packages are moving togobl.de.xinvoice, and importing that module here would be a cycle, so the key is written as a constant instead.No behaviour change, and it is compatible with both the current GOBL core and the one that no longer ships the German addons — so it can be released ahead of that change.