Add Finnish debit-transfer payment method translation - #146
Merged
Conversation
The Finnish locale was missing the debit-transfer key added to all other locales in #144, causing TestLocaleKeyCoverage/fi to fail. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
methodofaction
added a commit
that referenced
this pull request
Aug 25, 2026
Resolve locales/fi/app.yml conflict by keeping main's debit-transfer translation (Veloitussiirto) from #146. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds the missing
debit-transferpayment method translation to the Finnish locale (locales/fi/app.yml) as"Veloitussiirto", placed aftercredit-transferto match the key order used in the other locales.Why
#144 added the
debit-transferkey to all locales except Finnish (which was merged separately in #142), soTestLocaleKeyCoverage/fifails on main.Notes for reviewers
The
methodsblock in the Finnish file is defined once and shared via a YAML anchor (*payment_instructions), so this single line covers allbilling.*.payment.instructions.methods.debit-transferscopes.go test ./locales/...passes with this change.🤖 Generated with Claude Code