-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(ui): improve hotkey customization UX with interactive controls and validation #8649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(ui): improve hotkey customization UX with interactive controls and validation #8649
Conversation
…l Button from the Footer into the View
Co-authored-by: dunkeroni <[email protected]>
Co-authored-by: dunkeroni <[email protected]>
Co-authored-by: dunkeroni <[email protected]>
Co-authored-by: dunkeroni <[email protected]>
Co-authored-by: dunkeroni <[email protected]>
…-editor Copilot/add customizable hotkeys editor
- Created new HOTKEYS.md technical documentation for developers explaining architecture, data flow, and implementation details - Added user-facing hotkeys.md guide with features overview and usage instructions - Removed old CUSTOMIZABLE_HOTKEYS.md in favor of new split documentation - Expanded documentation with detailed sections on: - State management and persistence - Component architecture and responsibilities - Developer integration
|
I like the new functionality. Here are some comments on the UI:
Let me know your response to these points and I'll do the code review when the feature set is stable. |
|
I'm suggesting this pattern:
So there is no manual editing at all. Note that you will have to detect and warn when a chosen hotkey conflicts with a previously-assigned hotkey. You may handle it already: I didn't functionally check for this scenario. |
Summary
Type: Feature Enhancement (UI/UX)
What: Improved the hotkey editor UI with interactive modifier buttons, validation, and better user guidance.
Why: The previous hotkey editor required users to manually type modifier strings like "mod+", "ctrl+", "shift+", which was error-prone and unclear. Users had no guidance on valid syntax or immediate feedback on invalid combinations.
How:
+handlingdocs/features/hotkeys.md) and developer (docs/contributing/HOTKEYS.md) documentationScreenshots:
Edit mode with modifier buttons and help tooltip:
Screenshot
Related Issues / Discussions
QA Instructions
Test Modifier Buttons:
+handlingTest Validation:
mod+,shift+ctrl+(ending with modifier)mod+kTest Live Preview:
mod+a, ctrl+bTest Help Tooltip:
Test Functionality:
Merge Plan
No special merge requirements. This is a purely additive UI enhancement with no breaking changes.
Checklist
What's Newcopy (if doing a release after this PR) - Not applicable