Skip to content

refactor: model manager v3 #8607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 122 commits into from
Oct 14, 2025
Merged

refactor: model manager v3 #8607

merged 122 commits into from
Oct 14, 2025
+19,532 −14,038

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Oct 9, 2025 •
edited
Loading

Summary

This PR:

  • Refactors the model manager's identification (aka probing/classification) system. The new system is an evolution of the classify API introduced in Model classification api #7742. All legacy probe logic has been ported over to the new system, too.
  • Introduces the concept of "unknown" models (i.e. a model that we couldn't positively identify) so that a failure to identify a model doesn't require the user to re-download the model.
  • Normalizes model storage into a flat directory structure.
  • Introduces correctness tests for model identification (aka probing/classification). Previously, we did not test for correctness except for a very small number of cases. There is a detailed guide for adding test cases, which is pretty easy.

It adds 3 migrations:

  • Update the models table, removing the UNIQUE constraint on the combination of name, base and model type. The only unique thing for models is now the model's path on disk.
  • Migrate model configs in the DB where necessary.

This PR was previously split into 3 smaller PRs:

TODO

  • Update the model manager UI to let users fix an incorrectly-identified model. This is partially working.
  • Add guide for adding support for a new model type (identification, loading, testing).

Related Issues / Discussions

Gajillions of related issues.

QA Instructions

  • Because this PR does both DB and model file storage migrations, it needs careful testing on backed-up Invoke installs. I will add more detail about how to test it when I do the next alpha release.
  • The new model identification system works differently from the legacy probe and it is likely some things won't identify correctly. We'll need to test installing a variety of models, ideally adding them to the new model identification test suite.

Merge Plan

This will need an alpha release before RC.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added api python PRs that change python files Root invocations PRs that change invocations backend PRs that change backend files services PRs that change app services frontend PRs that change frontend files python-tests PRs that change python tests labels Oct 9, 2025
@psychedelicious psychedelicious mentioned this pull request Oct 9, 2025
Closed
5 tasks
@psychedelicious psychedelicious force-pushed the psyche/refactor/mm-3 branch 7 times, most recently from 2b3fdbe to 151dd4d Compare October 10, 2025 11:56
@psychedelicious
tests(mm): fix remaining MM tests
e5935a3
@psychedelicious
feat: allow users to edit models freely
3af42c5
@psychedelicious
feat(ui): add warning for model settings edit
9d9625f
@psychedelicious
tests(mm): flux state dict tests
ab1e15e
@psychedelicious
tidy: remove unused file
396f739
@psychedelicious
fix(mm): lora state dict loading in model id
7ff73eb
@psychedelicious
feat(ui): use translation string for model edit warning
e811ffc
@psychedelicious
docs(db): update version numbers in migration comments
f1ba95d
@psychedelicious
chore: bump version to v6.9.0a1
975d716
@psychedelicious
docs: update model id readme
bcc4735
@psychedelicious
tests(mm): attempt to fix windows model id tests
abbc96d
@psychedelicious
fix(mm): issue with deleting single file models
bab61fb
@psychedelicious
feat(mm): just delete the dir w/ rmtree when deleting model
6cea0c0
@psychedelicious
tests(mm): windows CI issue
fc10db4
@psychedelicious
fix(ui): typegen schema sync
644bb98
@psychedelicious
fix(mm): fixes for migration 23
e380521 
- Handle CLIP Embed and Main SD models missing variant field
- Handle errors when calling the discriminator function, previously only
handled ValidationError but it could be a ValueError or something else
- Better logging for config migration
@psychedelicious
chore: bump version to v6.9.0a2
7296a0c
@psychedelicious psychedelicious marked this pull request as ready for review October 14, 2025 22:52
@psychedelicious psychedelicious merged commit 454d05b into main Oct 14, 2025
41 checks passed
@psychedelicious psychedelicious deleted the psyche/refactor/mm-3 branch October 14, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@ebr ebr Awaiting requested review from ebr ebr is a code owner

Assignees

No one assigned

Labels

api backend PRs that change backend files frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files python-tests PRs that change python tests Root services PRs that change app services

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psychedelicious @hipsterusername