Skip to content

feat(ui): canvas bypass / send-to-gallery functionality #8279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Jul 14, 2025

Summary

Update the Save all images to gallery setting so that it also bypasses the Canvas staging area. In other words, when the setting is enabled, generations go straight to the gallery.

It's been renamed in the settings popover:
image

Queue generations effectively have the setting baked in. Once a queue item is created, you cannot change where it goes. This mirrors the behaviour of the oft-maligned Send to Gallery mode, which, while functionally similar, feels way less confusing.

Speaking of confusing - I found it rather confusing to have Save all images to gallery and Bypass canvas staging area as separate settings. So it's just a single setting.

The checkbox is still in the same place. I played with a separate button or drop-down by the Invoke button but it didn't feel good. When the setting is enabled, an warning-colored alert is displayed on Canvas:
image

The Canvas/Viewer panel tabs display progress as you'd expect:

  • When the current, active generation will be added to Canvas staging area, the Canvar tab has the mini progress bar.
  • When the current, active generation will bypass Canvas, the Viewer tab has the progress bar.

Supporting changes:

  • Clean up code related to canvas vs gallery sessions. This logic was related to a functionality that didn't survive v6 user feedback. Both components and logic were cleaned up.
  • Some empty layer placeholders had a button to go to the gallery. The gallery is no longer a tab you can "go to", so these buttons do nothing. Removed the button functionality, leaving the verbiage as static text.
  • Rework some of staging area logic around loading output images for display and autoswitching. This resolves an issue where auto-switch didn't work depending on your scroll position in the staging area.

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Jul 14, 2025
@psychedelicious psychedelicious force-pushed the psyche/feat/ui/canvas-bypass branch from e72e2f9 to df3c051 Compare July 16, 2025 08:00
@psychedelicious psychedelicious marked this pull request as ready for review July 16, 2025 08:00
@psychedelicious psychedelicious marked this pull request as draft July 16, 2025 08:12
@psychedelicious psychedelicious marked this pull request as ready for review July 16, 2025 09:02
Copy link
Member

@hipsterusername hipsterusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We can get it baking with folks

@psychedelicious psychedelicious force-pushed the psyche/feat/ui/canvas-bypass branch from 5377e14 to 5949975 Compare July 16, 2025 13:18
@psychedelicious psychedelicious enabled auto-merge (rebase) July 16, 2025 20:17
Simplify the canvas auto-switch logic to not rely on the preview images
loading. This fixes an issue where offscreen preview images didn't get
auto-switched to. Images are now loaded directly.
@psychedelicious psychedelicious force-pushed the psyche/feat/ui/canvas-bypass branch from 5949975 to a968f18 Compare July 16, 2025 20:17
@psychedelicious psychedelicious merged commit 18ad9a6 into main Jul 16, 2025
12 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/ui/canvas-bypass branch July 16, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants