Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port LoRA to new classification API #7849

Merged
merged 11 commits into from
Mar 31, 2025
Merged

Port LoRA to new classification API #7849

merged 11 commits into from
Mar 31, 2025
+225 −100

Conversation

jazzhaiku
Copy link
Collaborator

@jazzhaiku jazzhaiku commented Mar 27, 2025 •
edited
Loading

Summary

  • Port LoRA to new classification API
  • Add 2 additional tests cases (ControlLora and Flux Diffusers LoRA)
  • Moved ModelOnDisk to its own module

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files python-tests PRs that change python tests labels Mar 27, 2025
@jazzhaiku jazzhaiku changed the base branch from small-improvements to main March 28, 2025 01:11
@jazzhaiku jazzhaiku enabled auto-merge March 28, 2025 01:32
@psychedelicious psychedelicious self-requested a review March 31, 2025 05:08
@jazzhaiku jazzhaiku enabled auto-merge March 31, 2025 05:43
@jazzhaiku jazzhaiku merged commit bfb117d into main Mar 31, 2025
11 checks passed
@jazzhaiku jazzhaiku deleted the lora-classification branch March 31, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@hipsterusername hipsterusername hipsterusername approved these changes

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@ebr ebr Awaiting requested review from ebr ebr is a code owner

Assignees
No one assigned
Labels
backend PRs that change backend files python PRs that change python files python-tests PRs that change python tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jazzhaiku @psychedelicious @hipsterusername