Add FLUX Fill support #7780
Merged
Add FLUX Fill support #7780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
RyanJDick
force-pushed
the
ryan/flux-fill
branch
from
c83133c to
6bc0f1f
Compare
RyanJDick
requested review from
psychedelicious,
blessedcoolant,
maryhipp,
hipsterusername,
lstein,
brandonrising and
jazzhaiku
as code owners
hipsterusername
approved these changes
Mar 14, 2025
psychedelicious
force-pushed
the
ryan/flux-fill
branch
from
6bc0f1f to
73fa11f
Compare
psychedelicious
added a commit
that referenced
this pull request
Mar 23, 2025
In #7780 we added FLUX Fill support, and needed the probe to be able to distinguish between "normal" FLUX models and FLUX Fill models. Logic was added to the probe to check a particular state dict key (input channels), which should be 384 for FLUX Fill and 64 for other FLUX models. The new logic was stricter and instead of falling back on the "normal" variant, it raised when an unexpected value for input channels was detected. This caused failures to probe for BNB-NF4 quantized FLUX Dev/Schnell, which apparently only have 1 input channel. After checking a variety of FLUX models, I loosened the strictness of the variant probing logic to only special-case the new FLUX Fill model, and otherwise fall back to returning the "normal" variant. This better matches the old behaviour and fixes the import errors. Closes #7822
4 tasks
psychedelicious
added a commit
that referenced
this pull request
Mar 24, 2025
In #7780 we added FLUX Fill support, and needed the probe to be able to distinguish between "normal" FLUX models and FLUX Fill models. Logic was added to the probe to check a particular state dict key (input channels), which should be 384 for FLUX Fill and 64 for other FLUX models. The new logic was stricter and instead of falling back on the "normal" variant, it raised when an unexpected value for input channels was detected. This caused failures to probe for BNB-NF4 quantized FLUX Dev/Schnell, which apparently only have 1 input channel. After checking a variety of FLUX models, I loosened the strictness of the variant probing logic to only special-case the new FLUX Fill model, and otherwise fall back to returning the "normal" variant. This better matches the old behaviour and fixes the import errors. Closes #7822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for FLUX Fill (https://huggingface.co/black-forest-labs/FLUX.1-Fill-dev).
Note: FLUX Fill expects a
guidancevalue of ~30.0.Example
Workflow: flux_fill.json
Original
Mask
Result
Related Issues / Discussions
N/A
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)