feat: better graph validation errors

[psychedelicious]

Summary

• When validating edges, return the error message instead of just a boolean.
• When raising InvalidEdgeError, ensure we use that error message.
• Surface the error message to the user in the UI.
• Tweak the error toast to be a bit less cryptic.
• Fix issue with Any type fields not accepting collections
• Fix longstanding issue with iterate nodes not accepting connections from collect nodes

Error before:

Error after:

Related Issues / Discussions

Should help in troubleshooting the issue here https://discord.com/channels/1020123559063990373/1083864753543331981/1334888935242858506

Closes #3956

QA Instructions

@skunkworxdark Could you please try reproducing that issue with this PR? Hopefully it's easier to see what's going on.

For this specific issue, might need to set breakpoints for each of the 3 fail case returns in these two methods in graph.py to get the full picture:

• Graph._is_iterator_connection_valid()
• Graph._is_collector_connection_valid()

Merge Plan

n/a

Checklist

• The PR has a short but descriptive title, suitable for a changelog
• Tests added / updated (if applicable)
• Documentation added / updated (if applicable)
• Updated What's New copy (if doing a release after this PR)

[skunkworxdark]

The test case from the discord thread was reproduced. Creates a much better-looking error message.

However, it is a shame that the output of the Collect node can not go into an Any type or an Iterate node as it just makes for a slightly more complicated workflow by having to have it fed into the correct collection primitive first. I wonder if we could have an Iterate node where you can choose the output type or it dynamically decides what it is on the UI based on what is fed into it. I am sure you have been through this many times so feel free to ignore these ramblings of a slightly mad man.

[psychedelicious]

@skunkworxdark Thanks, I've fixed both issues:

• collect -> metadata item
• collect -> iterate

For collect -> iterate, we now traverse the graph to validate that the collector's input type matches all the iterate node's output connections.

For example, graphs like this should now work, because the collection types are compatible with all iterator outputs:

But graphs like this don't work, because we are feeding an integer to a color field:

We expect an error like this:

Can you please give this a spin again? @JPPhoto your review is also appreciated here

[skunkworxdark]

My testing for the PR is looking good and works fine for me with collect -> iterate. I also tested it with a few of my nodes that have any as input so collect -> Any is working well as well. Finally, tried it with a few of my Collect-Tools nodes that use a List[Any] as input these also seem to be working well