fix(app, expo): match scene-based AppDelegate for Expo SDK 58 config plugin - #9336
Merged
mikehardy merged 1 commit intoSep 23, 2026
Conversation
…plugin Expo SDK 58 starts React Native from the scene delegate, so the config plugin no longer finds self.moduleName or factory.startReactNative and skips FirebaseApp.configure().
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9336 +/- ##
=========================================
Coverage 69.81% 69.81%
Complexity 2129 2129
=========================================
Files 439 439
Lines 25518 25518
Branches 4257 4257
=========================================
Hits 17814 17814
Misses 6360 6360
Partials 1344 1344
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
russellwheatley
marked this pull request as ready for review
September 23, 2026 11:27
mikehardy
enabled auto-merge (rebase)
September 23, 2026 13:05
mikehardy
disabled auto-merge
September 23, 2026 13:06
mikehardy
deleted the
feature/cprn-495-expo-sdk-58-scene-based-appdelegate-config-plugin-skips
branch
September 23, 2026 13:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expo SDK 58 starts React Native from the scene delegate, so the config plugin no longer finds
self.moduleNameorfactory.startReactNative(and skipsFirebaseApp.configure().return super.application(application, didFinishLaunchingWithOptions: launchOptions)and insertFirebaseApp.configure()above itinternal import Expoas an anchor forimport FirebaseCoreMaintainer note: Fixes internal CPRN-495