Skip to content

fix(app, expo): match scene-based AppDelegate for Expo SDK 58 config plugin - #9336

Merged
mikehardy merged 1 commit into
mainfrom
feature/cprn-495-expo-sdk-58-scene-based-appdelegate-config-plugin-skips
Sep 23, 2026
Merged

mikehardy merged 1 commit into
mainfrom
feature/cprn-495-expo-sdk-58-scene-based-appdelegate-config-plugin-skips

Conversation

@russellwheatley

Copy link
Copy Markdown
Member

Expo SDK 58 starts React Native from the scene delegate, so the config plugin no longer finds self.moduleName or factory.startReactNative( and skips FirebaseApp.configure().

  • Also match return super.application(application, didFinishLaunchingWithOptions: launchOptions) and insert FirebaseApp.configure() above it
  • Treat internal import Expo as an anchor for import FirebaseCore
  • Add an SDK 58 fixture. Existing SDK 53 snapshots stay the same

Maintainer note: Fixes internal CPRN-495

…plugin

Expo SDK 58 starts React Native from the scene delegate, so the config plugin no longer finds self.moduleName or factory.startReactNative and skips FirebaseApp.configure().
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.81%. Comparing base (50a946a) to head (37d5fb2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9336   +/-   ##
=========================================
  Coverage     69.81%   69.81%           
  Complexity     2129     2129           
=========================================
  Files           439      439           
  Lines         25518    25518           
  Branches       4257     4257           
=========================================
  Hits          17814    17814           
  Misses         6360     6360           
  Partials       1344     1344           
Flag Coverage Δ
android-native 65.91% <ø> (ø)
e2e-ts-android 54.42% <ø> (ø)
e2e-ts-ios 53.89% <ø> (ø)
e2e-ts-macos 49.95% <ø> (ø)
ios-ruby 100.00% <ø> (ø)
jest 48.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@russellwheatley
russellwheatley marked this pull request as ready for review September 23, 2026 11:27

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@mikehardy
mikehardy enabled auto-merge (rebase) September 23, 2026 13:05
@mikehardy
mikehardy disabled auto-merge September 23, 2026 13:06
@mikehardy
mikehardy merged commit dce165d into main Sep 23, 2026
27 checks passed
@mikehardy
mikehardy deleted the feature/cprn-495-expo-sdk-58-scene-based-appdelegate-config-plugin-skips branch September 23, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛] Expo SDK 58 scene-based AppDelegate: config plugin skips FirebaseApp.configure()

2 participants