Skip to content

Conversation

ycmjason
Copy link
Contributor

@ycmjason ycmjason commented Sep 16, 2025

Description

#8611 flaged that many types are currently broken.

This PR fixes most of the type issues by removing <AppModelType, DbModelType> and replaced with <T extends DocumentData>.

Also added tsd to make sure our .d.ts are legit. Fixed many issues thanks to it!

Related issues

#8611

Release Summary

Fix types for firestore

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Added tsd to add some type testings to our apis.


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Sep 16, 2025 8:49am

@ycmjason ycmjason changed the title fix firestore types and add test types: fix firestore types and add test Sep 16, 2025
@ycmjason ycmjason changed the title types: fix firestore types and add test types(firestore): fix firestore types and add test Sep 16, 2025
@ycmjason ycmjason changed the title types(firestore): fix firestore types and add test types(firestore): improve firestore types and add test Sep 16, 2025
@ycmjason ycmjason changed the title types(firestore): improve firestore types and add test refactor(firestore): improve firestore types and add test Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant