Skip to content

fix(auth, ios): fixes inappropriate linking when host is nil #8517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

yjb94
Copy link
Contributor

@yjb94 yjb94 commented May 7, 2025

Description

I have a universal link that has nothing to do with firebase. but when i link into the url, the link has nil url host and falls into the generated expo prebuild linking code and returns NO. which is inappropriate and needed that url to pass to the very bottom of the linking delegate code.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

you can test with url with nullable(nil) url host. in my case, i tested with a custom universal link that has nothing to do with firebase app


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 7:53am

@CLAassistant
Copy link

CLAassistant commented May 7, 2025

CLA assistant check
All committers have signed the CLA.

@yjb94 yjb94 changed the title fix(auth,ios): fixes inappropriate branching when host is nil fix(auth,ios): fixes inappropriate linking when host is nil May 7, 2025
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yjb94 👋 this looks like a great change, I'd love to merge it - thank you for posting the PR. Could you sign the CLA as indicated in the details link for the failed CI check / and/or the CLA check comment? Thanks!

@mikehardy mikehardy changed the title fix(auth,ios): fixes inappropriate linking when host is nil fix(auth, ios): fixes inappropriate linking when host is nil May 12, 2025
@yjb94
Copy link
Contributor Author

yjb94 commented May 13, 2025

Hey @yjb94 👋 this looks like a great change, I'd love to merge it - thank you for posting the PR. Could you sign the CLA as indicated in the details link for the failed CI check / and/or the CLA check comment? Thanks!

i've signed for CLA :) thak you,

and i assume changing the title you just made PR Title cheking CI task failed. could you please check it? thank you

@mikehardy mikehardy enabled auto-merge (squash) May 13, 2025 03:31
@mikehardy mikehardy disabled auto-merge May 13, 2025 03:31
@mikehardy mikehardy merged commit f0cba0b into invertase:main May 13, 2025
14 of 18 checks passed
@mikehardy
Copy link
Collaborator

@yjb94 - yep, the title change was just so it would populate in the squash-merge github text box the way I wanted it. Merged and will release next time I publish - I just published a release today so it may be a couple days but it won't sit too long. We do small releases pretty frequently so things don't queue up. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants