Skip to content

chore: Allow type-safety for subcollections #8376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Allow type-safety for subcollections #8376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/firestore/lib/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,10 @@ export namespace FirebaseFirestoreTypes {
* to the location. The document at the referenced location may or may not exist. A `DocumentReference` can also be used
* to create a `CollectionReference` to a subcollection.
*/
export interface DocumentReference<T extends DocumentData = DocumentData> {
export interface DocumentReference<
T extends DocumentData = DocumentData,
C extends DocumentData = DocumentData,
> {
/**
* The Firestore instance the document is in. This is useful for performing transactions, for example.
*/
Expand Down Expand Up @@ -285,7 +288,7 @@ export namespace FirebaseFirestoreTypes {
*
* @param collectionPath A slash-separated path to a collection.
*/
collection(collectionPath: string): CollectionReference;
collection(collectionPath: string): CollectionReference<C>;

/**
* Deletes the document referred to by this DocumentReference.
Expand Down
Loading