results grid: pass correct value to results prop #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
approved these changes
Dec 12, 2023
jrcastro2
approved these changes
Dec 18, 2023
ntarocco
reviewed
Jan 19, 2024
| @@ -71,7 +71,7 @@ const Element = ({ overridableId, results, resultsPerRow }) => { | |||
| return ( | |||
| <Overridable | |||
| id={buildUID("ResultsGrid.container", overridableId)} | |||
| results={results} | |||
| results={_results} | |||
There was a problem hiding this comment.
@kpsherva @jrcastro2 given that you have reviewed this one.
IMO, I don't think this was 100% correct: the idea here is to pass the "raw" values, that would allow you to use results to build your own layout when overriding.
Passing _results means that when overriding, you get already a GridItem React cmp, instead of the list of results object, and you cannot easily change that cmp.
Can you please fix this?
Ping @zzacharo for any other opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/zenodo/rdm-project/issues/567
ResultsList, and also makes it easier to override this way.