selector: Allow the same value in multiple children aggregations

src/lib/components/BucketAggregation/BucketAggregationValues.js

@@ -139,7 +139,9 @@ const ValueElement = ({
     ? bucket.label
     : `${keyField} (${bucket.doc_count.toLocaleString("en-US")})`;
   const childAggCmps = getChildAggCmps(bucket);
-
+  /* Note that the checkbox does not have any `id`. It used to have one, based on the value, and the issue
+     was that, if the same value appeared more than once, react didn't like having two items with the same id,
+     and clicking on the second would select the first one */
   return (
     <Overridable
       id={buildUID("BucketAggregationValues.element", overridableId)}
@@ -152,7 +154,6 @@ const ValueElement = ({
       <List.Item key={bucket.key}>
         <Checkbox
           label={label}
-          id={`${bucket.key}-agg-value-checkbox`}
           value={bucket.key}
           onClick={() => onFilterClicked(bucket.key)}
           checked={isSelected}

src/lib/state/selectors/query.test.js

@@ -142,6 +142,41 @@ describe("queries with second level filters.", () => {
       ["type", "Publication"],
     ]);
   });
+
+  test("query with `subtype: Validation` should add it to the correct type", () => {
+    const state = [
+      ["file_type", "pdf"],
+      ["type", "Documentation", ["subtype", "Validation"]],
+    ];
+
+    const query = ["type", "Publication", ["subtype", "Validation"]];
+
+    const newState = updateQueryFilters(query, state);
+
+    expect(newState).toEqual([
+      ["file_type", "pdf"],
+      ["type", "Documentation", ["subtype", "Validation"]],
+      ["type", "Publication", ["subtype", "Validation"]],
+    ]);
+  });
+
+  test("query with `subtype: Validation` should remove it from the correct type", () => {
+    const state = [
+      ["file_type", "pdf"],
+      ["type", "Documentation", ["subtype", "Validation"]],
+      ["type", "Publication", ["subtype", "Validation"]],
+    ];
+
+    const query = ["type", "Publication", ["subtype", "Validation"]];
+
+    const newState = updateQueryFilters(query, state);
+
+    expect(newState).toEqual([
+      ["file_type", "pdf"],
+      ["type", "Documentation", ["subtype", "Validation"]],
+      ["type", "Publication"],
+    ]);
+  });
 });
 
 describe("queries with third level filters.", () => {