Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests: add missing facets and reorder #412

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

carlinmack
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

I have gone through all the existing requests and added the three which were missing (subcommunity, user moderation and legacy record upgrade).

I have also reordered and grouped them so that it is clear what request they refer to, as the label can be unclear. This grouping will be helpful for the eventual refactoring I mention in the following

Context:

For a request to display a proper type label in the request sidebar and in search facets, they must be defined in invenio-requests globally. This isn't great design as site-specific request types must be put into this module which should be unaware.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack
Copy link
Contributor Author

issue shelved #414

@slint slint merged commit 4ea19d2 into inveniosoftware:master Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants