services: proper escape the fiels key in links generation #1941
+28
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
approved these changes
Jan 29, 2025
jrcastro2
force-pushed
the
fix-escape-link
branch
from
8130ed3 to
799f8c1
Compare
jrcastro2
force-pushed
the
fix-escape-link
branch
from
799f8c1 to
6bf0996
Compare
kpsherva
reviewed
Feb 4, 2025
kpsherva
reviewed
Feb 5, 2025
| @@ -131,14 +133,15 @@ def test_iiif_info( | |||
| ## Testing with filename with a slash ## | |||
|
|
|||
| file_id = "test/image.png" | |||
| encoded_file_id = quote(file_id, safe="") | |||
There was a problem hiding this comment.
assert encoded_file_id == "test%BLAimage.png"
let's also check against a file with #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{+key} was keeping special characters unescaped by uritemplate
Tested locally upload of files within a directory, it seems to work fine.