Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove black version pin #98

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

tmorrell
Copy link
Contributor

@tmorrell tmorrell commented Jan 16, 2024

❤️ Thank you for your contribution!

Description

The black version pin is causing the CI to unnecessarily fail https://github.com/inveniosoftware/idutils/actions/runs/7509942198/job/20447716064#step:7:75, and black isn't pinned on other RDM repositories https://github.com/inveniosoftware/invenio-rdm-records/blob/e268c43c8e948c9872c3616eb59b49d97f7c7a4a/setup.cfg#L61

Picking a newer specific black version is another alternative.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@tmorrell tmorrell requested a review from utnapischtim January 16, 2024 17:28
@utnapischtim
Copy link
Contributor

i would change to pytest-black-ng, because pytest-black is not more supported and it raises a deprecation warning about BlackItem here which is annoying. In the other packages i changed to pytest-black-ng>=0.4.0

@tmorrell
Copy link
Contributor Author

Switched, thanks @utnapischtim

@utnapischtim utnapischtim merged commit 10b05b7 into inveniosoftware:master Jan 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released | Done 🚀
Development

Successfully merging this pull request may close these issues.

2 participants