URL: Relax check to ignore semicolons in URLs #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, another piece of evidence this change is needed. Could you add in the test from https://github.com/inveniosoftware/idutils/pull/92/files, and then we can get this merged finally. |
|
Actually, your PR has more goodies than this one. Closing in favor of yours. |
|
@tmorrell I tried rebasing your PR on master, but was denied permissions to push to the branch. |
* according to RFC 1738 section 2.2, semicolons are reserved but valid characters in URIs * `urllib.parse.urlparse()` interprets semicolons as `params` * thus, the check for no params in `is_url()` returns `False` for some valid URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115