Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor sentry section #145

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

egabancho
Copy link
Member

@egabancho egabancho commented Dec 13, 2024

invenio: refactor sentry block

* Deprecates non-camelcase sentry variables.

* Addresses secret handling as described in #117.

@egabancho egabancho force-pushed the sentry branch 2 times, most recently from a11c33a to 930141c Compare December 13, 2024 14:31
@egabancho egabancho changed the title invenio: refactor sentry block invenio: refactor Dec 13, 2024
@egabancho egabancho changed the title invenio: refactor invenio section refactor Dec 13, 2024
@egabancho egabancho marked this pull request as draft December 15, 2024 14:30
@egabancho egabancho force-pushed the sentry branch 2 times, most recently from 72ebfc6 to bf38b3f Compare December 16, 2024 10:40
@egabancho egabancho changed the title invenio section refactor refactor sentry section Dec 16, 2024
@egabancho egabancho force-pushed the sentry branch 2 times, most recently from aefb719 to 95af940 Compare December 16, 2024 10:44
@egabancho egabancho marked this pull request as ready for review December 16, 2024 10:45
@egabancho egabancho requested a review from lindhe December 16, 2024 10:45
charts/invenio/values.yaml Outdated Show resolved Hide resolved
charts/invenio/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@lindhe lindhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I don't use Sentry, I cannot test these changes. But as far as I can tell, it looks good and as long as you test it before merging you have my approval. 👍

@egabancho
Copy link
Member Author

I'm testing all the changes on our test instance. I will have to spin up a new one from scratch after the holiday break and test it there as well 😄

* Deprecates non-camelcase sentry variables.

* Addresses secret handling as described in inveniosoftware#117.
@egabancho egabancho merged commit c6d4708 into inveniosoftware:master Dec 16, 2024
@egabancho egabancho deleted the sentry branch December 16, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants