Change type of invenio.extra_env_from_secret

[lindhe]

Description

This change fixes a typo for the default value (and importantly: type) of the invenio.extra_env_from_secret value.

Before this change, I got the following warning when setting invenio.extra_env_from_secret:

coalesce.go:286: warning: cannot overwrite table with non table for invenio.invenio.extra_env_from_secret (map[])

This was because the default value of invenio.extra_env_from_secret was {} (the empty object) while it is clearly used as a list:

helm-invenio/charts/invenio/templates/web-deployment.yaml

Lines 83 to 89 in eb6544f

	{{- range .Values.invenio.extra_env_from_secret }}
	- name: {{ .name }}
	valueFrom:
	secretKeyRef:
	name: {{ .valueFrom.secretKeyRef.name }}
	key: {{ .valueFrom.secretKeyRef.key }}
	{{- end }}

helm-invenio/charts/invenio/templates/worker-deployment.yaml

Lines 87 to 93 in eb6544f

	{{- range .Values.invenio.extra_env_from_secret }}
	- name: {{ .name }}
	valueFrom:
	secretKeyRef:
	name: {{ .valueFrom.secretKeyRef.name }}
	key: {{ .valueFrom.secretKeyRef.key }}
	{{- end }}

So when setting invenio.extra_env_from_secret to a list instead of an object, Helm gets nervous. This change fixes that.

I've also added an example comment to show what the structure of each list item should be.

In the long term, I believe a more overarching change as discussed in #117 is better. My change here is just a quick bug fix.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings (for relevant code).
• I've followed the CSS/JS and React guidelines (for relevant code).
• I've followed the web accessibility guidelines (for relevant code).
• I've followed the user interface guidelines (for relevant code).
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[lindhe]

It seems like this did not fix the warning. Let me try some more before merge.

[lindhe]

False alarm! It did fix the bug, I just tested on the wrong branch. 🙃