Skip to content

switching latestReviews with reviews #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

switching latestReviews with reviews #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ sysgetassignment --date 2022-10-19 --type review
## Check badges

```
gh pr list -s all --json title,latestReviews > badges.json
gh pr list -s all --json title,reviews > badges.json
sysapprovedbadges badges.json
```

Expand Down
24 changes: 12 additions & 12 deletions badges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ def process_badges(json_output,file_out = None):
PR_list = json.load(f)

#filter for ones with reviews
reviewed = [(pr['title'], pr['latestReviews'][0])
for pr in PR_list if pr['latestReviews']]
# filter to only process approved ones latestReviews.state
# extract title, latestReviews.author.login, latestReviews.body,
reviewed = [(pr['title'], pr['reviews'][0])
for pr in PR_list if pr['reviews']]
# filter to only process approved ones reviews.state
# extract title, reviews.author.login, reviews.body,
logged_badges = [(title,review['author']['login'], review['body'])
for title,review in reviewed if review['state'] == 'APPROVED']

Expand Down Expand Up @@ -96,7 +96,7 @@ def process_badges(json_output,file_out = None):
# TODO: pair this with a commit to a "badges" branch, so it doesn't create conflicts


# review_df = badges_df['latestReviews'].apply(pd.Series)[0].apply(pd.Series)
# review_df = badges_df['reviews'].apply(pd.Series)[0].apply(pd.Series)
# author = review_df['author'].apply(pd.Series)


Expand All @@ -109,7 +109,7 @@ def cli_get_approved_titles(json_output,file_out = None):
'''
list PR titles from json or - to use std in that have been approved by an official approver

gh pr list -s all --json title,latestReviews
gh pr list -s all --json title,reviews


'''
Expand All @@ -124,7 +124,7 @@ def get_approved_titles(json_output, file_out = None):
Parameters
----------
json_output : filename
file generated from `gh pr list -s all --json title,latestReviews `
file generated from `gh pr list -s all --json title,reviews `
file_out : file name
file to be generated and store the output
'''
Expand All @@ -133,10 +133,10 @@ def get_approved_titles(json_output, file_out = None):
PR_list = json.load(f)

#filter for ones with reviews
reviewed = [(pr['title'], pr['latestReviews'][0])
for pr in PR_list if pr['latestReviews']]
# filter to only process approved ones latestReviews.state
# extract title, latestReviews.author.login, latestReviews.body,
reviewed = [(pr['title'], pr['reviews'][0])
for pr in PR_list if pr['reviews']]
# filter to only process approved ones reviews.state
# extract title, reviews.author.login, reviews.body,
logged_badges = [title for title,review in reviewed
if review['state'] == 'APPROVED' and
review['author']['login']in gh_approvers]
Expand Down Expand Up @@ -190,5 +190,5 @@ def get_approved_titles(json_output, file_out = None):
# runs-on: ubuntu-latest
# steps:
# - run: |
# gh pr list --state all --json title,latestReviews >>tmp
# gh pr list --state all --json title,reviews >>tmp
# process json to extract badges