feat: fix iOS url callback, add optional headers, use locale PR and more #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R0BB3RT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing some features regarding adding headers to the dropin calls. Our API needs authentication headers to be accessed. Also I noticed there were some problems with iOS regarding being callbacked from a iDEAL response, so that's also fixed.
Another thing that was also included now is a fix of credit card view not working for all apps on Android. This has to do with CardView not being able to inflate because of a wrong style. issue
I've also now set the target deployment version for iOS to the same as the Adyen SDK.
Also the service that needs to be provided in the AndroidManifest is now done in the plugin, so apps don't have to do it themselves anymore.
3DS secure was also fixed for Android since it was not actually executing it.
I've based this PR on the PR of @toonvanstrijp so the locale fix is also included.