fix: replace emoji with ASCII text to prevent Windows cp1252 crash#266
Open
ReynardL wants to merge 1 commit into
Open
fix: replace emoji with ASCII text to prevent Windows cp1252 crash#266ReynardL wants to merge 1 commit into
ReynardL wants to merge 1 commit into
Conversation
Python's default stdout encoding on Windows is cp1252, which cannot encode emoji characters. Error handlers crash with UnicodeEncodeError instead of displaying the actual warning/error message. Closes interviewstreet#265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print()andloggercalls with ASCII-safe text across 5 files[WARNING]/[ERROR]tagsProblem
On Windows, Python defaults to cp1252 encoding for stdout. Any
print()or log statement containing emoji crashes withUnicodeEncodeErrorwhen triggered:UnicodeEncodeError: 'charmap' codec can't encode characters in position 0-1
This affects all error/warning paths in the codebase. Users see a cryptic encoding crash instead of the actual diagnostic message.
Files changed
prompts/template_manager.pyscore.pypdf.pygithub.pyllm_utils.pyTesting
Verified on Windows 11 with Python 3.13 (cp1252 stdout) that all replaced messages print without errors. Black formatting applied.
Closes #265