[datastore_access] split crdb and ybdb logic; correct ybdb implementotion #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
force-pushed
the
datastore_access_ybdb
branch
4 times, most recently
from
f7cc660 to
207d84b
Compare
mickmis
approved these changes
Dec 9, 2025
monitoring/uss_qualifier/resources/interuss/datastore/datastore.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/resources/interuss/datastore/datastore.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/resources/interuss/datastore/datastore.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/resources/interuss/datastore/datastore_test.py
Outdated
Show resolved
Hide resolved
the-glu
force-pushed
the
datastore_access_ybdb
branch
from
207d84b to
908c48d
Compare
the-glu
force-pushed
the
datastore_access_ybdb
branch
2 times, most recently
from
e9e68a8 to
8e85e47
Compare
mickmis
approved these changes
Dec 11, 2025
monitoring/uss_qualifier/resources/interuss/datastore/datastore_test.py
Outdated
Show resolved
Hide resolved
the-glu
force-pushed
the
datastore_access_ybdb
branch
from
8e85e47 to
4e923dd
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 11, 2025
…tion (#1296) Co-authored-by: Mickaël Misbach <[email protected]> 471581b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1239 by testing 'correctly' yugabyte connections.
I created the PR but mostly implemented by @mickmis , I just did the final fixes to make it working 'for real' with yugabyte + finalized unit test (with a custom image for now).
Update:
The test have now been normalized between the two implementations, ssl has been renamed to tls, unit test have been updated and comments have been added.