Skip to content

Conversation

isc-pbarton
Copy link
Collaborator

resolves #819

If the cloned repo has a settings file, its values will overwrite those chosen earlier in the Configure prompts. I agree with the requestor that this is always desired behavior.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.77%. Comparing base (aef7832) to head (310ce67).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage   49.77%   49.77%           
=======================================
  Files          24       24           
  Lines        3281     3281           
=======================================
  Hits         1633     1633           
  Misses       1648     1648           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton
Copy link
Collaborator Author

Includes changes from #859 as well because I did not feel like resolving a merge conflict later.

Copy link
Collaborator

@isc-dchui isc-dchui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this PR also contains the changes for #859. Is that intentionally to avoid a merge conflict later? If so, will the git history correctly reflect that these changes are not actually from this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait sorry didn't see your earlier comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isc-dchui Yep, that was intentional to avoid merge conflict on the changelog. The history should be all good now - I merged #859 and changed the base on this repo to force GitHub to refresh its data associating commits to PRs.

@isc-pbarton isc-pbarton changed the base branch from main to issue-32 September 19, 2025 14:07
@isc-pbarton isc-pbarton changed the base branch from issue-32 to main September 19, 2025 14:07
@isc-pbarton isc-pbarton merged commit ea38138 into main Sep 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure script overwrites existing embeded-git-config.json file

3 participants