Skip to content

Copy Windows filesystem file correctly to isfs filesystem #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

Copy Windows filesystem file correctly to isfs filesystem #1658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96e1c46
Copy Windows filesystem file correctly to isfs filesystem
gjsjohnmurray Sep 24, 2025
c271dde
Merge remote-tracking branch 'upstream/master' into crimson-guan
gjsjohnmurray Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/providers/FileSystemProvider/FileSystemProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,18 @@ export function generateFileContent(
sourceContent: Uint8Array
): { content: string[]; enc: boolean; eol: vscode.EndOfLine } {
const sourceLines = sourceContent.length ? new TextDecoder().decode(sourceContent).split("\n") : [];
const eol = sourceLines.length && sourceLines[0].slice(-1) == "\r" ? vscode.EndOfLine.CRLF : vscode.EndOfLine.LF;

// Detect eol style (a return value), and if CRLF then strip the \r character from end of source lines
let eol = vscode.EndOfLine.LF;
if (sourceLines.length && sourceLines[0].slice(-1) == "\r") {
eol = vscode.EndOfLine.CRLF;
for (let i = 0; i < sourceLines.length; i++) {
if (sourceLines[i].slice(-1) == "\r") {
sourceLines[i] = sourceLines[i].slice(0, -1);
}
}
}

const fileExt = fileName.split(".").pop().toLowerCase();
const csp = fileName.startsWith("/");
if (fileExt === "cls" && !csp) {
Expand Down