Skip to content

Allow opening low-code editors from read-only file systems #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

Allow opening low-code editors from read-only file systems #1655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/providers/LowCodeEditorProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ export class LowCodeEditorProvider implements vscode.CustomTextEditorProvider {
.then(() => vscode.commands.executeCommand<void>("workbench.action.reopenTextEditor"));
}

async resolveCustomTextEditor(
document: vscode.TextDocument,
webviewPanel: vscode.WebviewPanel,
token: vscode.CancellationToken
): Promise<void> {
async resolveCustomTextEditor(document: vscode.TextDocument, webviewPanel: vscode.WebviewPanel): Promise<void> {
// Check that document is a clean, well-formed class
if (document.languageId != clsLangId) {
return this._errorMessage(`${document.fileName} is not a class.`);
Expand All @@ -38,12 +34,11 @@ export class LowCodeEditorProvider implements vscode.CustomTextEditorProvider {
if (!file) {
return this._errorMessage(`${document.fileName} is a malformed class definition.`);
}
if (!vscode.workspace.fs.isWritableFileSystem(document.uri.scheme)) {
const api = new AtelierAPI(document.uri);
if (!vscode.workspace.fs.isWritableFileSystem(document.uri.scheme) && lt(api.config.serverVersion, "2025.3.0")) {
return this._errorMessage(`File system '${document.uri.scheme}' is read-only.`);
}

const className = file.name.slice(0, -4);
const api = new AtelierAPI(document.uri);
if (!api.active) {
return this._errorMessage("Server connection is not active.");
}
Expand Down Expand Up @@ -108,7 +103,7 @@ export class LowCodeEditorProvider implements vscode.CustomTextEditorProvider {
</head>
<body>
<div id="content">
<iframe id="editor" title="Low-Code Editor" src="${targetOrigin}${api.config.pathPrefix}${webApp}/index.html?$NAMESPACE=${api.config.ns.toUpperCase()}&VSCODE=1&${
<iframe id="editor" title="Low-Code Editor" src="${targetOrigin}${api.config.pathPrefix}${webApp}/index.html?$NAMESPACE=${api.config.ns.toUpperCase()}&VSCODE=1${!vscode.workspace.fs.isWritableFileSystem(document.uri.scheme) ? "&READONLY=1" : ""}&${
webApp == this._rule ? "rule" : "DTL"
}=${className}" width="100%" height="100%" frameborder="0"></iframe>
</div>
Expand Down