Skip to content

Conversation

isc-bsaviano
Copy link
Contributor

@isc-bsaviano isc-bsaviano commented Sep 15, 2025

I'm opening this as a draft even though the code is ready for review because I think it should be merged just before a 3.2.0 release. This PR bumps the minimum supported VS Code version to 1.104.0 which we probably don't want to get in a 3.0.7 release if we need one.

@gjsjohnmurray
Copy link
Contributor

Shall we merge this and prepare a 3.2.0 release for next Monday?

@isc-bsaviano
Copy link
Contributor Author

I would like to wait for the early October VS Code because it should finalize the TerminalCompletionProvider. I need to add a little code to this extension to enable the Language Server to provide completions in terminals. I could add that code now and do a separate PR in a future release if it needs modification, but I would prefer to include it in 3.2.0. I will check with the VS Code team that that API is still on track for finalization.

@isc-bsaviano isc-bsaviano marked this pull request as ready for review September 26, 2025 12:38
@isc-bsaviano
Copy link
Contributor Author

Marking as ready for review because at this point 3.2.0 will be the next version. Whether we release that before or after the next VS Code version is still TBD.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isc-bsaviano isc-bsaviano merged commit dc95b9d into intersystems-community:master Sep 26, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the terminal-nonce branch September 26, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants