Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side improvements #1470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isc-bsaviano
Copy link
Contributor

This PR addresses feedback from a DC beta tester.

  • Limit concurrent file system reads on initial folder indexing to 250 to avoid EMFILE errors.
  • Limit concurrent file update REST requests to 50 to avoid overloading the server.
  • Always get the text of a document from the file system, even if VS Code has it loaded, to avoid concurrency issues when the file system updates before VS Code has updated its version.
  • Avoid unneeded file system reads after export by updating the document index using the already known text of the file that was exported.
  • New rate limiting utility code that is better documented

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I haven't tested it.

@isc-bsaviano
Copy link
Contributor Author

Thanks John. I will give the issue reporter at least a few days to respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants