Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more granular symbols for class members #1442

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Use more granular symbols for class members #1442

merged 2 commits into from
Oct 3, 2024

Conversation

isc-bsaviano
Copy link
Contributor

This PR fixes #1441. When this PR is approved, I will make a corresponding Language Server commit.

Here's what the old symbols looked like:
before

And here's the new ones:
after

gjsjohnmurray
gjsjohnmurray approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isc-bsaviano isc-bsaviano merged commit 0b00c74 into intersystems-community:master Oct 3, 2024
5 checks passed
@isc-bsaviano isc-bsaviano deleted the fix-1441 branch October 3, 2024 17:10
@isc-bsaviano isc-bsaviano mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isc-rsingh isc-rsingh isc-rsingh approved these changes

@gjsjohnmurray gjsjohnmurray gjsjohnmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outline view mixes Foreign Key and Trigger definitions together with Properties
3 participants
@isc-bsaviano @isc-rsingh @gjsjohnmurray