Better handling of generated INT routines in project folders #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjsjohnmurray
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Code change looks OK. I guess this makes the behaviour of the Project tree diverge from Explorer using isfs and displaying generated items, but we can probably justify this.
Having said that, I am not clear why people are putting generated INTs into a project in the first place.
|
@gjsjohnmurray The Projects Explorer and regular isfs both treat generated files as described in this PR's description, although the regular isfs change to enable it was a server-side change so I'm sure what versions it's in. This PR shouldn't affect many people, but it brings all of our explorers in line. |
isc-rsingh
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated INT routines shouldn't have their last dotted piece before the extension (e.g. the
1inUser.Test.1.int) split into a folder.