Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing link to new KPIs #1302

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

isc-bsaviano
Copy link
Contributor

IRIS BI KPI classes can be tested by opening them as a web page. This PR adds a link that can be opened in a browser so the testing page is easily accessible.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link will only be valid on the server the class was created on, and in the namespace it was created in. Where source control or similar is being used to promote code between environments and/or namespaces to test, stage and deploy it the URL will become stale.

Did you consider implementing a CodeLens? Yes, this would only offer the testing launch when the class is viewed inside VS Code. But it would work correctly as the class moves.

@isc-bsaviano
Copy link
Contributor Author

@gjsjohnmurray Good suggestion! I'll do that in a new PR.

@isc-bsaviano isc-bsaviano merged commit 7a0df21 into intersystems-community:master Jan 22, 2024
7 checks passed
@isc-bsaviano isc-bsaviano deleted the kpi-link branch January 22, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants