WEBDEV-6636 Delay scrolling to page until content has loaded in #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
&page=parameter is set initially on a page equipped with collection browser, it is intended to scroll immediately to that page in the infinite scroller. However, recently this has been flaky especially on our profile pages, where usage of collection browser across multiple tabs slightly complicates the setup, resulting in the scroll being attempted before the infinite scroller has begun rendering enough placeholder items to provide a scroll target.This PR just ensures that if we try to perform that initial page scroll before the infinite scroller is ready to handle it, that we instead just set a flag and postpone the scroll until it becomes possible.