fix ssl=no #49
Open
fix ssl=no #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 16, 2017 13:02
| HAS_CERT=`$VESTA_PATH/bin/v-get-web-domain-value $USER $DOMAIN SSL` | ||
| if [[ $HAS_CERT == 'no' ]] | ||
| HAS_CERT=`$VESTA_PATH/bin/v-list-web-domain-ssl $USER $DOMAIN` | ||
| if [[ $HAS_CERT == '' ]] |
There was a problem hiding this comment.
There is a better way to detect empty strings with bash scripting. In fact this method is used earlier on in this script.
Use this instead:
if [[ -z "$HAS_CERT" ]]
For documentation purposes, it is noteworthy that the new v-list-web-domain-ssl script either returns nothing (when there is no certificate) or the details of the certificate itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi
I already change a bit in here
but dunno its work or not :D
found on other solution but not committed
thanks