-
Notifications
You must be signed in to change notification settings - Fork 59
Unskip working testcases #2094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unskip working testcases #2094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to unskip previously disabled test cases that are now working locally, allowing them to run in CI to verify they don't have remaining issues. The changes remove numerous test case names from the skip list for XPU tests.
- Remove skipped test cases for float64, uint8, and various precision data types (bfloat16, float16, float32, int8) that are now working
- Remove skipped test cases related to matrix operations (addbmm, addmm, addmv, baddbmm, bmm, etc.) across different data types
- Remove skipped test cases for norm_fro operations and nonzero_xpu test
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sure, I'll wait. As my PR is subset of #1825, I will probably just close my PR |
These test work locally - unskipping to test if there are still any issues in CI