Skip to content

Conversation

Silv3S
Copy link
Contributor

@Silv3S Silv3S commented Sep 22, 2025

These test work locally - unskipping to test if there are still any issues in CI

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 08:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to unskip previously disabled test cases that are now working locally, allowing them to run in CI to verify they don't have remaining issues. The changes remove numerous test case names from the skip list for XPU tests.

  • Remove skipped test cases for float64, uint8, and various precision data types (bfloat16, float16, float32, int8) that are now working
  • Remove skipped test cases related to matrix operations (addbmm, addmm, addmv, baddbmm, bmm, etc.) across different data types
  • Remove skipped test cases for norm_fro operations and nonzero_xpu test

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chuanqi129 chuanqi129 requested a review from daisyden September 23, 2025 05:53
Copy link
Contributor

@daisyden daisyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daisyden
Copy link
Contributor

daisyden commented Sep 24, 2025

Hi, @Silv3S , we have a PR #1825 to clean up the skiplist for all the test files. Could you please hold on this PR and do it after #1825? And we plan to do automation to regularly conduct the skiplist clean up. Any good suggestions please let us know.

@Silv3S
Copy link
Contributor Author

Silv3S commented Sep 24, 2025

Sure, I'll wait. As my PR is subset of #1825, I will probably just close my PR

@dvrogozh dvrogozh marked this pull request as draft October 3, 2025 15:45
@dvrogozh
Copy link
Contributor

dvrogozh commented Oct 3, 2025

Sure, I'll wait. As my PR is subset of #1825, I will probably just close my PR

I've converted PR to the draft to avoid accidental merge. Please, undo if PR is still needed after #1825.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants