Skip to content

Roll back to EU copy for AB buffer in Sort kernel #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev/sycl-free-func
Choose a base branch
from
Open

Roll back to EU copy for AB buffer in Sort kernel #2072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions src/ATen/native/xpu/sycl/SortingKernels.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,13 @@ void segmented_radix_sort_pairs_downsweep_kernel(

// ======================= large sort =======================

template <typename scalar_t>
struct ABBufferCopyFunctor {
scalar_t operator()(scalar_t x) const {
return x;
}
};

template <
typename key_t,
typename value_t,
Expand Down Expand Up @@ -409,18 +416,20 @@ void segmented_radix_sort_pairs_kernel(
auto input_calc = TrivialOffsetCalculator<2>();
at::detail::Array<char*, 2> data;
if (keys_out) {
auto q = at::xpu::getCurrentSYCLQueue();
q.memcpy(
(void*)keys_out,
(void*)keys_temp,
sizeof(key_t) * num_segments * num_elements);
data[0] = (char*)keys_out;
data[1] = (char*)keys_temp;
auto fn = ABBufferCopyFunctor<key_t>();
auto vec_size = memory::can_vectorize_up_to<decltype(fn)>(data);
launch_vectorized_kernel(
num_segments * num_elements, fn, data, input_calc, vec_size);
}
if (values_out) {
auto q = at::xpu::getCurrentSYCLQueue();
q.memcpy(
(void*)values_out,
(void*)values_temp,
sizeof(value_t) * num_segments * num_elements);
data[0] = (char*)values_out;
data[1] = (char*)values_temp;
auto fn = ABBufferCopyFunctor<value_t>();
auto vec_size = memory::can_vectorize_up_to<decltype(fn)>(data);
launch_vectorized_kernel(
num_segments * num_elements, fn, data, input_calc, vec_size);
}
}
}
Expand Down