Skip to content

Conversation

Silv3S
Copy link
Contributor

@Silv3S Silv3S commented Sep 17, 2025

Fixes #1823

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 13:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes infinite loops in polynomial kernel calculations when NaN values are encountered by adding early termination conditions. The fix prevents the kernels from hanging when computing Hermite, Laguerre, and Legendre polynomials with NaN inputs.

Key changes:

  • Added NaN checks to loop conditions in polynomial kernel implementations
  • Removed corresponding test skip entries that were previously failing due to hangs

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/xpu/skip_list_common.py Removed skip entries for polynomial tests that previously hung
src/ATen/native/xpu/sycl/LegendrePolynomialPKernel.cpp Added NaN check to prevent infinite loop in Legendre polynomial calculation
src/ATen/native/xpu/sycl/LaguerrePolynomialLKernel.cpp Added NaN check to prevent infinite loop in Laguerre polynomial calculation
src/ATen/native/xpu/sycl/HermitePolynomialHeKernel.cpp Added NaN check to prevent infinite loop in Hermite He polynomial calculation
src/ATen/native/xpu/sycl/HermitePolynomialHKernel.cpp Added NaN check to prevent infinite loop in Hermite H polynomial calculation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@CuiYifeng CuiYifeng added this pull request to the merge queue Sep 23, 2025
Merged via the queue into intel:main with commit 229e8ba Sep 23, 2025
49 of 50 checks passed
@Silv3S Silv3S deleted the test_hang branch September 23, 2025 14:04
mengfei25 added a commit that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The unit tests will hang up on some cases.
4 participants