[EISW-141730] 19.x Merge dialect changes #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,4 +44,3 @@ add_subdirectory(UB) | |||
| add_subdirectory(Utils) | |||
| add_subdirectory(Vector) | |||
| add_subdirectory(X86Vector) | |||
There was a problem hiding this comment.
This looks a bit radical. Is it possible to introduce a cmake option for disabling the dialect?
Something like we have for spirv:
There was a problem hiding this comment.
I see. Based on the comment in the JIRA I thought we are doing a permanent cleanup. My initial solution was to disable using CMake options like you pointed above. I will proceed with CMake option then.
sramasit
force-pushed
the
sramasit/19.x
branch
2 times, most recently
from
9e422f7 to
98b43c9
Compare
sramasit
changed the title
andrey-golubev
requested changes
Apr 24, 2025
nikita-kud
force-pushed
the
npu/release/19.x
branch
from
ccbe9ff to
2e54baf
Compare
sramasit
force-pushed
the
sramasit/19.x
branch
6 times, most recently
from
e0c9905 to
9668fe3
Compare
nikita-kud
reviewed
May 16, 2025
Introduced a CMake option MLIR_DIALECT_XEGPU_ENABLE (default OFF) to optionally include the XeGPU dialect in the build. Signed-off-by: Surendar Rama Sitaraman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.