-
Notifications
You must be signed in to change notification settings - Fork 29
[EISW-141730] 19.x Merge dialect changes #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: npu/release/19.x
Are you sure you want to change the base?
Conversation
@@ -44,4 +44,3 @@ add_subdirectory(UB) | |||
add_subdirectory(Utils) | |||
add_subdirectory(Vector) | |||
add_subdirectory(X86Vector) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit radical. Is it possible to introduce a cmake option for disabling the dialect?
Something like we have for spirv:
if(MLIR_DIALECT_SPIRV_ENABLE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Based on the comment in the JIRA I thought we are doing a permanent cleanup. My initial solution was to disable using CMake options like you pointed above. I will proceed with CMake option then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
9e422f7
to
98b43c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bring this into the upstream first? And start a general discussion on the granularity of the MLIR? Otherwise, this is going to live forever in our repo which has a maintenance cost.
ccbe9ff
to
2e54baf
Compare
e0c9905
to
9668fe3
Compare
Introduced a CMake option MLIR_DIALECT_XEGPU_ENABLE (default OFF) to optionally include the XeGPU dialect in the build. Signed-off-by: Surendar Rama Sitaraman <[email protected]>
No description provided.