Skip to content

[EISW-141730] 19.x Merge dialect changes #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: npu/release/19.x
Choose a base branch
from

Conversation

sramasit
Copy link
Contributor

@sramasit sramasit commented Apr 22, 2025

No description provided.

@sramasit sramasit requested a review from a team as a code owner April 22, 2025 05:30
@@ -44,4 +44,3 @@ add_subdirectory(UB)
add_subdirectory(Utils)
add_subdirectory(Vector)
add_subdirectory(X86Vector)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit radical. Is it possible to introduce a cmake option for disabling the dialect?

Something like we have for spirv:

if(MLIR_DIALECT_SPIRV_ENABLE)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Based on the comment in the JIRA I thought we are doing a permanent cleanup. My initial solution was to disable using CMake options like you pointed above. I will proceed with CMake option then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sramasit sramasit force-pushed the sramasit/19.x branch 2 times, most recently from 9e422f7 to 98b43c9 Compare April 24, 2025 01:51
@sramasit sramasit changed the title EISW-163563 Permanently disable XeGPU dialect support [EISW-141730] 19.x Merge dialect changes Apr 24, 2025
Copy link
Contributor

@andrey-golubev andrey-golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bring this into the upstream first? And start a general discussion on the granularity of the MLIR? Otherwise, this is going to live forever in our repo which has a maintenance cost.

@sramasit sramasit force-pushed the sramasit/19.x branch 6 times, most recently from e0c9905 to 9668fe3 Compare April 29, 2025 05:08
sramasit added 2 commits May 28, 2025 17:21
Introduced a CMake option MLIR_DIALECT_XEGPU_ENABLE (default OFF) to optionally include the XeGPU dialect in the build.

Signed-off-by: Surendar Rama Sitaraman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants