Skip to content

[SYCL] Improve all_specialization_constant_native() #8630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2023
Merged

[SYCL] Improve all_specialization_constant_native() #8630

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c534a7
[SYCL] Implement native_specialization_constant()
KornevNikita Mar 9, 2023
44d8588
[SYCL] Improve all_specialization_constant_native()
KornevNikita Mar 13, 2023
2eb2041
Merge remote-tracking branch 'intel_llvm/sycl' into native_specializa…
KornevNikita Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions sycl/source/detail/device_image_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,17 +112,13 @@ class device_image_impl {
bool all_specialization_constant_native() const noexcept {
// Specialization constants are natively supported in JIT mode on backends,
// that are using SPIR-V as IR
auto IsAOTBinary = [](const char *Format) {
return (
(strcmp(Format, __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV64_X86_64) ==
0) ||
(strcmp(Format, __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV64_GEN) == 0) ||
(strcmp(Format, __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV64_FPGA) == 0));
auto IsJITSPIRVTarget = [](const char *Target) {
return (strcmp(Target, __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV64) == 0 ||
strcmp(Target, __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV32) == 0);
};

return !IsAOTBinary(MBinImage->getRawData().DeviceTargetSpec) &&
(MContext.get_backend() == backend::opencl ||
MContext.get_backend() == backend::ext_oneapi_level_zero);
return (MContext.get_backend() == backend::opencl ||
MContext.get_backend() == backend::ext_oneapi_level_zero) &&
IsJITSPIRVTarget(MBinImage->getRawData().DeviceTargetSpec);
}

bool has_specialization_constant(const char *SpecName) const noexcept {
Expand Down