[DevASAN] Move memory alloc info into DeviceInfo #20611
Open
+89
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since CPU/GPU device both support USM indirect access, we need to poison shadow of whole allocated memory in the device instead of only one context.
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
commented
Nov 11, 2025
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
|
I think this PR is causing UR hangs, please make sure it's fixed before running CI again, thanks. |
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
approved these changes
Nov 13, 2025
pbalcer
approved these changes
Nov 14, 2025
Contributor
pbalcer
left a comment
pbalcer
left a comment
There was a problem hiding this comment.
lgtm, just two small comments.
| } | ||
| }; | ||
|
|
||
| struct USMLaunchInfo { |
Contributor
There was a problem hiding this comment.
no need to address this now, but it might be useful to unify this with the tsan launch info.
| } | ||
| // UR doesn't allow GlobalWorkOffset is null, we need to construct a zero | ||
| // value array if user doesn't specify its value. | ||
| if (GlobalWorkOffset) { |
Contributor
There was a problem hiding this comment.
global work offset can be null, see:
llvm/unified-runtime/include/ur_api.h
Lines 7857 to 7859 in d10b37e
If something is segfaulting when null is passed to launch kernel, please file a bug or let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CPU/GPU device both support USM indirect access, we need to poison shadow of whole allocated memory in the device instead of only one context.