Skip to content

[libspirv] use CLC fmax/fmin for __spirv_ocl_fmax/min_common #20402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[libspirv] use CLC fmax/fmin for __spirv_ocl_fmax/min_common #20402

wants to merge 1 commit into from
+10 −28

Conversation

@wenju-he
Copy link
Contributor

Because OpenCL fmax/fmin common functions also use CLC fmax/fmin.

Move the __spirv_ocl_fmax/min_common into common folder because they are common instructions.

@wenju-he
[libspirv] use CLC fmax/fmin for __spirv_ocl_fmax/min_common
f4c5e85 
Because OpenCL fmax/fmin common functions also use CLC fmax/fmin.

Move the __spirv_ocl_fmax/min_common into common folder because they
are common instructions.
@wenju-he wenju-he requested a review from a team as a code owner October 20, 2025 08:40
@wenju-he wenju-he mentioned this pull request Oct 22, 2025
Merged
@wenju-he
Copy link
Contributor Author

The failing native-cpu tests

Failed Tests (3):
  SYCL :: Basic/built-ins/const_vec_common.cpp
  SYCL :: Basic/built-ins/marray_common.cpp
  SYCL :: Basic/built-ins/vec_common.cpp

will be fixed by llvm/llvm-project#164546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenju-he @bratpiorka @steffenlarsen