-
Notifications
You must be signed in to change notification settings - Fork 804
[SYCL][UR] Support sycl_ext_oneapi_clock #20070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
@intel/unified-runtime-reviewers-level-zero hi guys, could you please help to figure out how to check if this feature supported by a L0-device? IGC supports it already, but I don't know if there are any restrictions from the L0 side. Should I just somehow check the version of IGC? |
sycl/test-e2e/Experimental/clock.cpp
Outdated
@@ -1,3 +1,6 @@ | |||
// UNSUPPORTED: cpu | |||
// UNSUPPORTED-INTENDED: Bug in CPU RT. Waiting for the new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be a bug report link/reference instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR to fix this was already merged (not to the release branch), so we'll get the fix with the next major release I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we somehow track issues related to the CPU/GPU RT update? So we can notice that this should be updated with the new RT version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a small patch to set "REQUIRES-INTEL-DRIVER: cpu: 2026" here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also updated the test there, so these changes are not needed anymore 8d32f59
I've updated the description, please check if that was accurate. |
Spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_clock.asciidoc
The test for this exists, but isn't being tested due to issues down the stack, see #20100.