[Driver][SYCL][Test] Fix tests fails when libclc project is disabled #20030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests fail since 388ccf5 when libclc project is disabled, since there is no libspirv bitcode file. Fix them by adding `-fno-sycl-libspirv` flag. Add `REQUIRES: libclc` to libspirv specific tests.
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
changed the title
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Maetveis
requested changes
Sep 10, 2025
Maetveis
reviewed
Sep 10, 2025
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
approved these changes
Sep 10, 2025
Maetveis
approved these changes
Sep 10, 2025
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hchilama
approved these changes
Sep 10, 2025
srividya-sundaram
approved these changes
Sep 10, 2025
|
@intel/llvm-gatekeepers please merge, thanks. It is not clear to me why Jenkins/Precommit fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 388ccf5, tests fail when the libclc project is disabled
because the libspirv bitcode file is missing.
Fix them by adding
-fno-sycl-libspirvflag.Add
-ccc-install-dirfor libspirv specific tests.