[NFCI][SYCL] Reduce dependencies of <sycl/range.hpp>
#20029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
North star goal: compile
```cpp
namespace syclext = sycl::ext::oneapi;
namespace syclexp = sycl::ext::oneapi::experimental;
SYCL_EXT_ONEAPI_FUNCTION_PROPERTY((syclexp::nd_range_kernel<1>))
void foo(int *p) {
size_t id = syclext::this_work_item::get_nd_item<1>().get_global_linear_id();
p[id] = 0;
}
```
as fast as possible by limiting number of necessary includes.
`item`/`nd_item`/`nd_range`/etc. are all dependent on `range`, so the
first tiny step would be to speed up its compilation as much as possible.
aelovikov-intel
requested review from
mmichel11,
sergey-semenov and
AlexeySachkov
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Sep 9, 2025
AlexeySachkov
approved these changes
Sep 10, 2025
adamfidel
approved these changes
Sep 10, 2025
|
@intel/syclcompat-lib-reviewers, ping. |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 11, 2025
Pre-commit CI didn't catch because several parallel PRs were needed to expose it.
aelovikov-intel
added a commit
that referenced
this pull request
Sep 11, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 11, 2025
Regressed with the build) after intel#20029, similarly to the build itself. The build was fixed earlier in intel#20057, but that wasn't enough to fix `check-sycl` on Win.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 11, 2025
Regressed after intel#20029, similarly to the build itself. The build was fixed earlier in intel#20057, but that wasn't enough to fix `check-sycl` on Win. Do it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
North star goal: compile
as fast as possible by limiting number of necessary includes.
item/nd_item/nd_range/etc. are all dependent onrange, so the first tiny step would be to speed up its compilation as much as possible.