Skip to content

[NFC][SYCL] Add devices_range helper to cleanup persistent_device_code_cache #19405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

aelovikov-intel
Copy link
Contributor

Same idea as with nodes_range from
#19295, this PR generalizes the approach and makes both nodes_|devices_range use the same common utility.

persistent_device_code_cache was chosen randomly to apply simplifications by using the new helper. Subsequent PRs will likely make wider usage of it.

…code_cache`

Same idea as with `nodes_range` from
intel#19295, this PR generalizes the
approach and makes both `nodes_|devices_range` use the same common
utility.

`persistent_device_code_cache` was chosen randomly to apply
simplifications by using the new helper. Subsequent PRs will likely make
wider usage of it.
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor questions

@aelovikov-intel aelovikov-intel merged commit de4f28a into intel:sycl Jul 11, 2025
47 of 51 checks passed
@aelovikov-intel aelovikov-intel deleted the devices_range branch July 11, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants